Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ripples hotspot and some refactoring #2

Merged
merged 2 commits into from Feb 3, 2015
Merged

Fix ripples hotspot and some refactoring #2

merged 2 commits into from Feb 3, 2015

Conversation

eveliotc
Copy link
Contributor

@eveliotc eveliotc commented Dec 8, 2014

  • [FIX] Fix item ripple hotspot, it was always center
  • [ADD] Introduce OverlayLinearLayout to reduce nested layouts
  • [DRY] Refactor item layouts being copied over and over, demo how to use attrs and resources override

@eveliotc
Fix ripples hotspot and some refactoring
6a70315 
- [FIX] Fix item ripple hotspot, it was always center
- [ADD] Introduce OverlayLinearLayout to reduce nested layouts
- [DRY] Refactor item layouts being copied over and over, demo how to use attrs and resources override
@eveliotc
Copy link
Contributor Author

eveliotc commented Dec 8, 2014

@Musenkishi thanks for this app, after wallbase died this is probably the best one around, wanted to fix something that was driving me nuts: ripples not being drawn from the actual hot spot, instead they were always being drawn right in the center, ended up doing some refactoring as there is a lot of duplicated/unnecessary code

@eveliotc
Copy link
Contributor Author

eveliotc commented Dec 8, 2014

Just one comment more to demonstrated the difference:

Before:
broken-ripples

After:
fixed-ripples

Musenkishi added a commit that referenced this pull request Feb 3, 2015
@Musenkishi
Merge pull request #2 from eveliotc/fix-ripples
f0fc47f 
Fix ripples hotspot and some refactoring
@Musenkishi Musenkishi merged commit f0fc47f into Musenkishi:master Feb 3, 2015
@Musenkishi
Copy link
Owner

Nice work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eveliotc @Musenkishi