command/file: add command "readlyrics" #1851
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code doesn't authoritatively distinguish the lyrics type. So having that field dones't really help. If explicit synced lyrics were to be added it would make more sense to have a different command than to distinguish them by type field of a command that only returns it's first result.
|
Is "command/file: fix indents in lyrics related changes" a fixup commit for some bad changes in a previous commit of this PR? If yes, please amend the bad commits, as this makes your PR hard to review. |
|
no reply |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #653
I rebased the branch and changed
readlyricsto have the same command API and binary response asreadpicture/albumartand ignore additional lyrics tags if there is more than one, likereadpicturedoes.Big thanks to https://github.com/NBonaparte for doing all of the original work!
Closes #350