Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StringBuilder shouldn't be marked as IMMUTABLE #194

Open
paplorinc opened this issue Oct 3, 2022 · 0 comments
Open

StringBuilder shouldn't be marked as IMMUTABLE #194

paplorinc opened this issue Oct 3, 2022 · 0 comments

Comments

@paplorinc
Copy link

paplorinc commented Oct 3, 2022

StringBuilder is definitely NOT immutable, but most of the mutations seem to happen in the parent, in AbstractStringBuilder which don't seem to be considered:

    @Test
    void validate_StringBuilder() {
        var analysisSession = DefaultCachingAnalysisSession.createWithCurrentClassPath(NO_CONFIGURATION);
        assertEquals(NOT_IMMUTABLE, analysisSession.resultFor(Dotted.fromClass(StringBuilder.class)).isImmutable);
    }

results in

expected: <NOT_IMMUTABLE> but was: <IMMUTABLE>
Expected :NOT_IMMUTABLE
Actual   :IMMUTABLE
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant