Adds support for Let's Encrypt x Certbot #52
Conversation
AntociAlin
changed the title
AntociAlin
changed the title
There was a problem hiding this comment.
I checked the functionality and it is mostly correct. In addition to the comments in code, please consider the following:
- The domain change functionality does not work. If you have the domain
dev.mutablesecurity.ioinitially set and then change tostaging.mutablesecurity.io, the certificate remains the same. It should change as well, with the new domain. - Replace all the
/var/log/nginx/https_{UserDomain.get()}_access.logoccurrences withLogLocation.get(). This indirection decrease the code size and helps further changes (with the additional level of indirection). - If you have pyinfra operations, use them. I saw a lot of
server.shell(command="rm"despite the fact that you could usefile.file(present=False. - Group the objects by types. See the file structure in the documentation.
- Check the phrases (descriptions for objects and pyinfra operations) to be valid.
- Lint the code.
- Remove the
code.py.oldfile.
|
For the first comment, and that is: The domain change functionality does not work. If you have the domain dev.mutablesecurity.io initially set and then change to staging.mutablesecurity.io, the certificate remains the same. It should change as well, with the new domain. |
|
@AntociAlin, as this version of the module supports only one domain, let's just revoke the old one and generate a new certificate. |
|
I have added the latest commit, where I've fixed almost every issued presented by you. There is one more issue left, and that is the generation and revocation of certificates when the user changes the domain or the email. The issue occurs only at the |
|
I've fixed all the issues presented above. Please do look into this PR one more time and if everything is in order, then it should be ready to merge with main. |
This commit implements the refactored version of Let's Encrypt x Certbot for the new MutableSecurity structure. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
This commit fixes the issues flagged by George-Andrei Iosif <georgeiosif@live.com>. There is one more issue left. The issue represents the generation and revocation of certificates when the user changes the domain or the email. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
This commit fixes all the SET_INFORMATION issues that have been presented in the past few weeks. There have been a few changes to the code also to be able to run everything smoothly. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
This commit modifies the flow of the code. The main two functions: GENERATE and REVOKE have been broken apart and integrated into _install and _uninstall. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
This commit changes some of the shell functions to typical pyinfra functions to handle all requests better. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
This commit adds the apt.py file into the common.operations directory. This file contains the apt operation autoremove. This way every module from this point onward will be able to use the most common apt functions in a more fluid way. Resolves: #51 Signed-off-by: AntociAlin <antoci.alin97@gmail.com>
* Creates a documentation generation module Moves functionality from the script generating README.md into a new module, autodoc, that will help generating Markdown spec sheets too. Resolves: #39 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com> * Implements the auto-generation of documentation Implements the code for generating automatically the documentation for solutions integration. The output will be further be taken by a GitHub action and placed into the future web-based documentation. As some code from the CLI module was required in the autodoc one, the functionality was moved into a visual_proxy module to allow the code sharing. Resolves: #39 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com> * Generates a solution index Generates a JSON solution index, from the details already extracted to generate the spec sheets, to be push into website's repository. In addition, it changes the unit testing workflow to run only when changes occurs in tested folders (with Python 3 code inside). Resolves: #39 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com> * Adds new workflows and outputs Adds the workflows for generating the spec sheets and triggering a workflow from website's repository. Resolves: #39 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com> * Renames the word "status" Only replaces occurances of "status" with "maturity". Resolves: #39 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com>
Solves some warnings generated by linters and adds some punctuation. Resolves: #51 Signed-off-by: George-Andrei Iosif <georgeiosif@live.com>
This reverts commit e67e27c.
Metadata
Proposed Changes
New Functioning
Let's Encrypt x Certbot will be able to generate a certificate for a single domain. It supports only Nginx for the moment.