Update ldk 121, bdk alpha5, bitcoin 0.30 #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wasm tests failing |
|
Finally got all tests passing. While debugging ended up fixing a TODO for not needing the password to get the logs so made that a separate commit still need to actually test manually, but leaving that for a future date |
benthecarman
force-pushed
the
ldk-121
branch
2 times, most recently
from
d9ea370
to
8bfedb8
Compare
benthecarman
force-pushed
the
ldk-121
branch
2 times, most recently
from
ff82a33
to
ad28850
Compare
benthecarman
force-pushed
the
ldk-121
branch
4 times, most recently
from
896e495
to
df21fb8
Compare
|
When through our testing guide and everything seems to work, only thing that I couldn't test was payjoin because it seems the server is down right now. Also tested that I can safely upgrade a wallet and everything seems to be working properly. |
TonyGiorgio
requested changes
Feb 13, 2024
benthecarman
force-pushed
the
ldk-121
branch
from
df21fb8
to
bfca73f
Compare
TonyGiorgio
approved these changes
Feb 13, 2024
|
Rocketship Shaka Shake emoji
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't think i have everything fully working yet, got it compiling and i'll finish this later
Most of the diff is from the removal of
to_hex(), they claim theto_string()should be usable but this seems ripe for bugs to accidentally occur so I am just using thehexcrate for everywhere that isn't a log.