Handle specific errors from the LSP upon invoice #601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
futurepaul
approved these changes
Jun 16, 2023
TonyGiorgio
force-pushed
the
lsp-proposal-errors
branch
from
e1d44cc
to
ba4f117
Compare
benthecarman
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will give us more indication of what went wrong during invoice creation. The common reasons are because the user is not connected to the LSP or the LSP has ran out of confirmed funds.
@futurepaul you should review the API logic here.
The proposed changes I would like
mutiny-webto do is to check the error oncreate_bip21for an Lsp related error and fall back toget_new_addressif that's the case. This is so that you may show the user the connection error or lsp funding error, but still allow them to proceed with receiving on chain funds with that warning in mind.Relies on https://github.com/voltagecloud/lsp-server/pull/138
Related to MutinyWallet/mutiny-web#249