Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change password #638

Merged
merged 2 commits into from Jul 8, 2023
Merged

Change password #638

merged 2 commits into from Jul 8, 2023

Conversation

benthecarman
Copy link
Collaborator

wasn't working for me when testing, getting this code for now

Wait for idb to save after changing password
@futurepaul
Copy link
Contributor

need to throw an error on export if password required

@TonyGiorgio TonyGiorgio marked this pull request as ready for review July 8, 2023 05:13
@TonyGiorgio TonyGiorgio changed the title WIP: Change password Change password Jul 8, 2023
@TonyGiorgio
Copy link
Contributor

TonyGiorgio commented Jul 8, 2023

Should work now. Also swapped out the encryption method, and stored the key in memory for multiple writes.

Should also throw an error on export if it can't decrypt the mnemonic.

Copy link
Collaborator Author

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one thing

mutiny-wasm/src/lib.rs Outdated Show resolved Hide resolved
Copy link
Collaborator Author

@benthecarman benthecarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TonyGiorgio TonyGiorgio merged commit b3938c1 into master Jul 8, 2023
9 checks passed
@TonyGiorgio TonyGiorgio deleted the change-password branch July 8, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants