Add util function for hodl invoice detection #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
force-pushed
the
hodl-inv
branch
from
52cdd0c
to
f10dd71
Compare
TonyGiorgio
reviewed
Jan 23, 2024
|
|
||
| /// If the invoice is from a node that gives hodl invoices | ||
| #[wasm_bindgen] | ||
| pub async fn is_potential_hodl_invoice(invoice: String) -> Result<bool, MutinyJsError> { |
There was a problem hiding this comment.
Why is this needed? Don't we already warn users when paying zeus that it is a hodl invoice? Something is already doing that logic somewhere based on the list of pubkeys.
There was a problem hiding this comment.
In the front end we only warn for lightning address by checking for @zuespay.com
TonyGiorgio
approved these changes
Jan 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to keep the disction between test and non test for the list, just keeping the
ONE_KEYin there because no one will ever have it anyways