Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: left-aligned preview images #86

Open
dominicus opened this issue May 19, 2016 · 4 comments
Open

Request: left-aligned preview images #86

dominicus opened this issue May 19, 2016 · 4 comments

Comments

@dominicus
Copy link
Contributor

Since titles are now left-aligned, it may look better to also align preview images on piece-info pages to the left, so they land below the piece title on piece-info pages.
See sample http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=640

image

@chrissawer
Copy link
Contributor

I have implemented this (by accident) when adding SVG preview images. It can currently be seen on one piece only - The Entertainer:
http://www.mutopiaproject.org/cgibin/piece-info.cgi?id=263
I think my personal preference however is to leave them centered. What do other people think? I'm happy to go with the majority.

@glenl
Copy link
Contributor

glenl commented Dec 21, 2016

While we have centered tabular data, I would prefer centered images. I'm not sure the tabular format works for this kind of data presentation --- the columns don't mean anything that I can discern. If we ever switch to simple left-aligned data then a left-aligned preview image would be appropriate.

@dominicus
Copy link
Contributor Author

The top menu, logo, and title look nice left-aligned, but I find the later switch to centered preview creates an unexpected visual jog and white space under the title.

image

Re-arranging the piece information would be a further improvement.
The download links could come sooner...and icons might give good visual cues and help those on tablets or smaller screens:
image

For general info fields, a left-aligned list would work better than the dual-column table:
image

@chrissawer
Copy link
Contributor

I have put the image back to centered for now in mutopia.css for both PNG and SVG previews - but happy for the discussion to continue and changes to be made if consensus can be reached.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants