Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Fody Weavers #1124

Closed
Cheesebaron opened this issue Aug 31, 2015 · 5 comments
Closed

Use Fody Weavers #1124

Cheesebaron opened this issue Aug 31, 2015 · 5 comments
Labels
s/wont-fix Won't fix status

Comments

@Cheesebaron
Copy link
Member

Some types such as MvxCachingFragmentActivity would be nice to use Fody Weavers or similar to only have one class, but have it derive from different types of Activities.

@bspinner
Copy link
Contributor

Just took a brief look on Fody - would this also clean up the copypasta I had to "implement" for the Droid Support Leanback project?

@kjeremy
Copy link
Contributor

kjeremy commented Apr 18, 2016

Something like Mixins might work.

@Cheesebaron
Copy link
Member Author

I think we can revisit this for MvvmCross 5.x now that everything is in the same repo. Will make it easier to use weavers.

@nickrandolph
Copy link
Contributor

@Cheesebaron with the consolidation in 6 is this still necessary?

@Cheesebaron
Copy link
Member Author

Probably not. However, we should consider using support packages for all our Android stuff. Since that is the recommended way to go from Google either way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s/wont-fix Won't fix status
Development

No branches or pull requests

5 participants