New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup "Sidebar" plugin #2626

Closed

nmilcoff opened this issue Feb 18, 2018 · 1 comment · Fixed by #2660

Labels

p/ios up-for-grabs

Milestone

Contributor

nmilcoff commented Feb 18, 2018

In #2530 the old iOS Support was moved into the plugins folder and rethought as a plugin, as you can see here.

The problem is that project did not only contain an implementation for a sidebar menu, but also a few more utility methods / classes.

We need to cleanup this before 6.0 hits stable!

nmilcoff added Future cleanup up-for-grabs p/ios labels

nmilcoff added this to the 6.0.0 milestone

martijn00 mentioned this issue

Delete empty IMvxModalIosView #2660

Merged

4 tasks

Contributor

martijn00 commented Mar 6, 2018

This was already done in the upgrade. I moved the util classes to the main library. I just made a PR to clean the last file.

martijn00 closed this as completed in #2660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment