Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

NavigationService doesn't wait for the view to appear in ios #3289

Closed
2 of 7 tasks
abdomh opened this issue Feb 17, 2019 · 0 comments
Closed
2 of 7 tasks

NavigationService doesn't wait for the view to appear in ios #3289

abdomh opened this issue Feb 17, 2019 · 0 comments
Labels
p/ios iOS platform t/bug Bug type
Milestone

Comments

@abdomh
Copy link
Contributor

abdomh commented Feb 17, 2019

馃悰 Bug Report

in ios When navigating through navigation service to another view model the navigation will run and return before the navigation is completed, will also fire AfterNavigation Event before navigation has completed.

this happens because the code responsible for showing view model in MvxIosViewDispatcher doesn't know about the task being executed as it's action is stored in Action instead of Func<Task> which in turn results on an asynchronous execution

Expected behavior

When awaited it should not return until the navigation is completed

Reproduction steps

Navigate from ViewModelA to ViewModelB and do something after navigation it will execute before the navigation is completed in ios only

Configuration

Version: 6.x

Platform:

  • 馃摫 iOS
  • 馃 Android
  • 馃弫 WPF
  • 馃寧 UWP
  • 馃崕 MacOS
  • 馃摵 tvOS
  • 馃悞 Xamarin.Forms
@martijn00 martijn00 added this to the 6.2.4 milestone Mar 19, 2019
@martijn00 martijn00 added the t/bug Bug type label Mar 19, 2019
@Cheesebaron Cheesebaron added the p/ios iOS platform label Mar 23, 2019
@martijn00 martijn00 modified the milestones: 6.2.4, 6.3.0 May 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p/ios iOS platform t/bug Bug type
Development

No branches or pull requests

3 participants