Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove System.ServiceModel from Cirrious.MvvmCross.Plugins.File #394

Closed
guillaumejay opened this issue Aug 13, 2013 · 5 comments
Closed

Comments

@guillaumejay
Copy link

I believe that Cirrious.MvvmCross.Plugins.File is referencing system.ServiceModel without needing it.
But because it's referenced, any IOS/Android project using this plugin must be done with Business Edition of Xamarin, which is a lot more expensive than the Indie one.

@iamahern
Copy link

Just hit the same issue as well. At least for the features / plugins I referenced, I was able to comment it out to no ill effect. I am only looking at Android using the base CrossCore/MvvmCross features + the File & SqlLite plugins.

I was not hitting this in the past, so I think this is a recent licencing change :(

@brianchance
Copy link
Contributor

The System.Xml.Serialization (.Touch and .Droid) also reference System.ServiceModel. It is type forwarding XmlSerializerFormatAttribute.

Not sure if it is needed or not, but the nuget package adds a reference by default.

@brianchance
Copy link
Contributor

I took a look through all the projects and it is referenced, but not used, in these projects. I have removed the reference and all compile fine. I can make a pull request if necessary.

Cirrious.MvvmCross.AutoView
CrossUI.Core
Cirrious.MvvmCross.Plugins.Bookmarks
Cirrious.MvvmCross.Plugins.Color
Cirrious.MvvmCross.Plugins.DownloadCache
Cirrious.MvvmCross.Plugins.Email
Cirrious.MvvmCross.Plugins.File
Cirrious.MvvmCross.Plugins.Json
Cirrious.MvvmCross.Plugins.JsonLocalization
Cirrious.MvvmCross.Plugins.Location
Cirrious.MvvmCross.Plugins.PhoneCall
Cirrious.MvvmCross.Plugins.PictureChooser
Cirrious.MvvmCross.Plugins.ResourceLoader
Cirrious.MvvmCross.Plugins.Share
Cirrious.MvvmCross.Plugins.SoundEffects

@dtodaro-ascendle
Copy link

I just ran into this issue as well. I'd love to see this addressed if possible.

@slodge
Copy link
Contributor

slodge commented Aug 23, 2013

Closing this - merging into #397

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

5 participants