Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete project #1

Merged
merged 4 commits into from Jan 12, 2022
Merged

Complete project #1

merged 4 commits into from Jan 12, 2022

Conversation

Mwapsam
Copy link
Owner

@Mwapsam Mwapsam commented Jan 11, 2022

  • Configure Webpack to bundle Modular JavaScript
  • Configure linters (ESLint, StyleLint & Webhint)
  • Add HTML, CSS & JavaScript files
  • Update README file

Copy link

@leolpaz leolpaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mwapsam ,

While you made a great effort in this project, unfortunately, I cannot proceed to review your code.

Invalid Code Review Request

You have submitted a project, that doesn't pass Linters

Your Code Review Request will be marked as invalid in your Dashboard, so please submit a new one once you are ready 🙏

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


Invalid Code Review Request does not count into the code reviews limit.

@github-pages github-pages bot temporarily deployed to github-pages January 11, 2022 22:19 Inactive
@github-pages github-pages bot temporarily deployed to github-pages January 11, 2022 22:24 Inactive
@github-pages github-pages bot temporarily deployed to github-pages January 11, 2022 22:54 Inactive
Copy link

@descholar-ceo descholar-ceo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Mwapsam ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.


As described in the Code reviews limits policy you have only 3 code reviews per project. If you think that the code review was not fair, you can request a second opinion using this form.

@Mwapsam Mwapsam merged commit 973b8b7 into main Jan 12, 2022
@Mwapsam Mwapsam deleted the main-feature branch January 12, 2022 05:07
@Mwapsam Mwapsam restored the main-feature branch January 15, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants