Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readme caveat re URL escaping #1247

Open
JakeQZ opened this issue Dec 19, 2023 · 0 comments
Open

Add readme caveat re URL escaping #1247

JakeQZ opened this issue Dec 19, 2023 · 0 comments
Milestone

Comments

@JakeQZ
Copy link
Contributor

JakeQZ commented Dec 19, 2023

See #646.

Due to the way Emogrifier works internally by using DOMDocument, any lack of true replication of actual HTML markup when processed through loadHtml and then saveHtml will be evident in the output.

This includes

  • URL-escaping of URL attributes, which may break templating engines.

Workarounds are possible, typically involving a str_replace before and after Emogrification.

This issue should be noted in the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants