Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Incomer]: Better handling of Dispatcher State #138

Closed
Rossb0b opened this issue Nov 23, 2023 · 0 comments
Closed

[Incomer]: Better handling of Dispatcher State #138

Rossb0b opened this issue Nov 23, 2023 · 0 comments
Labels
Refactorisation Changes without functionality

Comments

@Rossb0b
Copy link
Member

Rossb0b commented Nov 23, 2023

The code below is used to check that previously published Events are well published. It only does it on the interval where the Incomer instance defined the Dispatcher as Alive.
If the Dispatcher is NOT Alive, we just skip until we receive a ping and so consider the Dispatcher instance as Alive.

Actually, this part of the code is useless as long as the Incomer and the Dispatcher share the same instance, yet, it is run for two reasons,

  • If the Dispatcher class fails out, a new Dispatcher will take relay & so the pre-defined Incomer instance will start receiving ping events. At this moment, the Incomer isn't synchronized anymore with the Dispatcher, so running the function is a MUST-HAVE.
  • If the Env var is wrong, again, the Incomer is not synced, and will receive ping events, so running the function is MUST-HAVE.

Actually, that part of the code works properly, but the two points I just raised are not highlighted in the code, so it makes it difficult to maintain.

image

@Rossb0b Rossb0b added enhancement New feature or request Refactorisation Changes without functionality and removed enhancement New feature or request labels Nov 23, 2023
@Rossb0b Rossb0b closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Refactorisation Changes without functionality
Projects
None yet
Development

No branches or pull requests

1 participant