[RFC] CLI #10
[RFC] CLI #10
Conversation
danielterwiel
force-pushed
the
dani_clap_cli
branch
from
fbf43df
to
2d24384
Compare
danielterwiel
force-pushed
the
dani_clap_cli
branch
3 times, most recently
from
526a9e8
to
5d650e5
Compare
cli/src/main.rs
Outdated
| println!("HTTP development server listening on {}", http_addr); | ||
| println!("RPC server listening on {}", rpc_addr); | ||
|
|
||
| let () = if !is_peer_connected("127.0.0.1:3001".parse().unwrap()).await { |
There was a problem hiding this comment.
🤔 what if we tried just polling the Echo endpoint of the RPC server a few times in a loop with a delay after each poll. Its very hacky - but it'll give us confirmation that the server is started.
cli/proto/development.proto
Outdated
| @@ -0,0 +1,29 @@ | |||
| // FIXME: this is a copy of /development_server/proto/development.proto | |||
There was a problem hiding this comment.
Do we have to do anything here? Why did we have to copy this fella?
There was a problem hiding this comment.
Quoting @SuddenlyHazel 😄:
it prob makes sense to eventualy get this into its own package.
But, for now feel free to just repeat the boilerplate in the CLI.
Update: Sharing .proto files across workspaces is harder than it seems. Wasted too much time on it past two days
Update 2: Managed to get it working 😅: b84f79e
There was a problem hiding this comment.
Next step would be to also move the entirety of tonic into its own package I assume?
|
|
||
| loop { | ||
| let rpc_addr = format!("http://{}:{}", domain, rpc_port); | ||
| let state = server_state(rpc_addr, just_started).await; |
There was a problem hiding this comment.
no-op here
Just bringing this to your attention for future Tokio hacking purposes
There was a problem hiding this comment.
Wondering what you mean by no-op. When I println! the value of state it is in fact looping till the development_state is Echo'able:
Running `target/debug/cli start`
[2023-09-26T13:27:46Z INFO cli] Starting development server
[2023-09-26T13:27:46Z INFO cli] Started development server
🪵 [main.rs:252]~ token ~ state = StartingUp
🪵 [main.rs:252]~ token ~ state = StartingUp
[2023-09-26T13:27:48Z WARN cli] Development server already listening
🪵 [main.rs:252]~ token ~ state = Started
[2023-09-26T13:27:48Z INFO cli] You can reach the development server on http://127.0.0.1:3001
[2023-09-26T13:27:48Z INFO cli] handle_stderr: Finished dev [unoptimized + debuginfo] target(s) in 0.33s
Added: - background Changed: - `component_path` to `component`
Running into: tonic::transport::Error upon cargo run deploy
danielterwiel
force-pushed
the
dani_clap_cli
branch
from
11474f0
to
b19a02a
Compare
|
Ship it 🥳 . This is looking great. I think we can move forward here :). We can always come back to clean things up in the future. |
Usage:
Available commands inside the workspace:
cargo run: shows available CLI commandscargo run build: builds project using xtaskcargo run start: starts dev servercargo run stop: stops dev servercargo run deploy: deploys component to path