Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Action: Fix exit status #155

Open
forslund opened this issue Oct 3, 2021 · 0 comments
Open

Github Action: Fix exit status #155

forslund opened this issue Oct 3, 2021 · 0 comments

Comments

@forslund
Copy link
Collaborator

forslund commented Oct 3, 2021

Currently master will show an angry red X if the version was not changed. This is due to the fact that the tag-if-needed will not set the version and lazily just report that all is good leading to the Create Mycroft-core PR stage triggering without the version output from the previous stage being set, leading to an invalid version being detected.

Not sure what the best action is, if we move the setting of the version output earlier it should work but looks a bit like the next stage would try to create a PR even if the version didn't change.

Another way would be to mark the stages to be allowed to fail.

Best would be if there is a way to set a conditional and only continue to run the following step if a conditional was set.

I will try to look into it during the week but posting here as an explanation for the current red X on master. (and if anyone else feels like digging into it)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant