Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing hard coded /tmp/ for some instances in the code #2727

Closed
dzekem opened this issue Oct 21, 2020 · 1 comment · Fixed by #2892
Closed

Replacing hard coded /tmp/ for some instances in the code #2727

dzekem opened this issue Oct 21, 2020 · 1 comment · Fixed by #2892
Labels
Good first issue Good issue for new contributors help wanted Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality.

Comments

@dzekem
Copy link
Contributor

dzekem commented Oct 21, 2020

/tmp/ has been hard coded in some instances

This will be replaced with https://docs.python.org/3/library/tempfile.html which has been well implemented in some instances in the code.
@forslund
Copy link
Collaborator

Agreed, I thought we'd been better regarding this but you're right it's very much needed!

@forslund forslund added Good first issue Good issue for new contributors help wanted Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality. labels Oct 21, 2020
@krisgesling krisgesling linked a pull request Oct 30, 2020 that will close this issue
Bugfix/issue 2727 #2740
Closed
@krisgesling krisgesling mentioned this issue Apr 30, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good first issue Good issue for new contributors help wanted Type: Refactoring and other improvements Improvement of code and documentation that does not alter functionality.
Projects
None yet
Milestone
No milestone
2 participants
@forslund @dzekem