Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt keywords / regexes aren't removed together with intents. #2866

Closed
forslund opened this issue Mar 18, 2021 · 2 comments · Fixed by #2877
Closed

Adapt keywords / regexes aren't removed together with intents. #2866

forslund opened this issue Mar 18, 2021 · 2 comments · Fixed by #2877

Comments

@forslund
Copy link
Collaborator

The adapt intent service doesn't remove the registered vocabularies when a skill is unloaded, it unloads the intent itself but neither regexes or keywords are removed. Meaning if a skill has a vocab file

test.voc

stew
meatballs

and it is changed to

stew
carrots

meatballs will still be a match. The same goes for regexes.

The intents themselves are removed correctly so if an intent is removed completely it won't match any longer but as long as an intent is reused all previous registered vocabs will be available.

Not sure if this is a core issue or an adapt issue, since adapt doesn't implement the detach code.

@forslund
Copy link
Collaborator Author

It's a bit tricky on the detach_intent to scan for orphaned keywords since keywords can be shared between intents but the method used to clean up after a skill could probably do it fairly(TM) easy.

@forslund
Copy link
Collaborator Author

This issue should be solved by #2877

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants