Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set STT response encoding to utf-8 (deepspeech local) #2902

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

nutzl
Copy link

@nutzl nutzl commented May 7, 2021

Description

Setting STT response encoding to utf-8 for local deepspeech server, by setting encoding attribute of urllib-response to utf-8 to omit encoding auto-detection, that fails sometimes.

How to test

Use Mycroft with local deepspeech server with German language model: umlauts aren't encoded correctly and therefore response is not understood.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft
Copy link

Hello, @nutzl, thank you for helping with the Mycroft project! We welcome everyone
into the community and greatly appreciate your help as we work to build an AI
for Everyone.

To protect yourself, the project, and users of Mycroft technologies we require
a Contributor Licensing Agreement (CLA) before accepting any code
contribution. This agreement makes it crystal clear that along with your
code you are offering a license to use it within the confines of this project.
You retain ownership of the code, this is just a license.

Please visit https://mycroft.ai/cla to initiate this one-time signing. Thank
you!

@devops-mycroft devops-mycroft added the CLA: Needed Need signed CLA from https://mycroft.ai/cla label May 7, 2021
@devops-mycroft
Copy link

Voight Kampff Integration Test Succeeded (Results)

@krisgesling
Copy link
Contributor

Hey there, thanks for helping to improve Mycroft!

Would you be able to see if the Content-Type header of the response contains the charset value of "utf-8"?

If it does then we could use that value, which should work in the event that the response is not UTF-8 encoded.

Any opinions from those reading along on whether this is a concern or likely?

@MycroftAI MycroftAI deleted a comment from codecov-commenter May 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Needed Need signed CLA from https://mycroft.ai/cla
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants