Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mycroft-config: Fix deprecated --tempfile in nano #3140

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Tony763
Copy link
Contributor

@Tony763 Tony763 commented Oct 26, 2022

Description

As described in Issue #3124, --tempfile was deprecated in Nano version 5.0.

Switching to --saveonexit would break function on older versions (Ubuntu 20.04 LTS use 4.8 version).

Thankfully, the short version of those two is still the same -t. Using it will preserve function on older systems and fix function on newer ones.

How to test

Try to edit config.

Contributor license agreement signed?

CLA [x] (Whether you have signed a CLA - Contributor Licensing Agreement

@devops-mycroft devops-mycroft added the CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) label Oct 26, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 54.05% // Head: 54.04% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (d1b9fa2) compared to base (48dd100).
Patch has no changes to coverable lines.

❗ Current head d1b9fa2 differs from pull request most recent head c4ac8ba. Consider uploading reports for the commit c4ac8ba to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #3140      +/-   ##
==========================================
- Coverage   54.05%   54.04%   -0.01%     
==========================================
  Files         120      120              
  Lines       11032    11032              
==========================================
- Hits         5963     5962       -1     
- Misses       5069     5070       +1     
Impacted Files Coverage Δ
mycroft/client/speech/listener.py 48.04% <0.00%> (-0.36%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@devops-mycroft
Copy link

Voight Kampff Integration Test Failed (Results).
Mycroft logs are also available: skills.log, audio.log, voice.log, bus.log, enclosure.log

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA: Yes Contributor License Agreement exists (see https://github.com/MycroftAI/contributors) hacktoberfest-accepted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants