Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add acknowledgement response after confirm install dialogue #72

Open
brierjon opened this issue May 27, 2021 · 1 comment
Open

Add acknowledgement response after confirm install dialogue #72

brierjon opened this issue May 27, 2021 · 1 comment

Comments

@brierjon
Copy link

Is your feature request related to a problem? Please describe.
I'm always frustrated when installing a new skill from the Marketplace and MyCroft asks for my confirmation that I want to install a skill, but I can't tell that it heard me and it started to install the requested skill. The only acknowledgement to a user after a request to install is when the skill install completes. Depending on the network, size and complexity of the skill to be installed, and processing of device an intermediary acknowledgement would be useful to make the install more intuitive. Right now the lack of an acknowledgement leaves too long a gap between the confirmation and install which can feel like the device did not hear the confirmation to install the skill and that it fell back to listening for a new command instead of installing.

Describe the solution you'd like
Add an acknowledgement response between the "install.confirm.dialog" of "Confirming: Shall I install {{skill}} by {{author}}." and "install.complete.dialog" - "{{skill}} is now installed and ready for use". Ideally with a state indicator that an install is in progress. An acknowledgement should

Solution 1. add "I'm now installing {{skill}} and will let you know when it is ready." and a install progress indicator on the device screen or lights (Mark1 & Mark2 - could display "installing {{skill name}}" as text)
Solution 2. add "I'm now installing {{skill}} and will let you know when it is ready."

@krisgesling
Copy link
Contributor

Hi Jonathan, thanks for raising this.

We've got the Installer Skill on our list to get a GUI which should help immensely on the Mark II but I agree that this could be improved for all systems as we can't guarantee that there will be a screen or visual feedback available.

One thing to consider is that whilst some Skills can take time to install, others install very quickly. So it would be good to consider this in our dialog.
Eg we could end up with lots of dialog being spoken in one big long stretch:

I'm now installing {{skill}} and will let you know when it is ready. The {{skill}} Skill is now ready for use.

Some other options might be:

  • a positive acknowledge tone giving a subtle notification that the confirmation was accepted
  • something relatively short such as "let me get that"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants