Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We should add hash wrappers as well for all Sui/Narwhal used functions #48

Closed
kchalkias opened this issue Sep 16, 2022 · 3 comments
Closed
Assignees

Comments

@kchalkias
Copy link
Collaborator

kchalkias commented Sep 16, 2022

This will help to avoid surprises in Sui or Narwhal re using different sha2/sha3/keccak deps in different places. Ideally we should control every crypto algorithm in fastcrypto. After having these wrappers, we should update both Narwhal and Sui repos by invoking fastcrypto's api.

I was thinking that the same applies for base64, but let's wait for this, as Rust's popular base64 crate is working on the malleability fix.

@jonas-lj jonas-lj linked a pull request Sep 20, 2022 that will close this issue
@jonas-lj
Copy link
Contributor

@kchalkias Do we also need BLAKE2? It's used a few places in fastcrypto, but only in tests where it could be replaced with any other hash function.

@kchalkias
Copy link
Collaborator Author

@jonas-lj we'll need all major hash functions currently used indeed.

@jonas-lj
Copy link
Contributor

The hash functions are added and there's an issue on the SUI repo to add them there (MystenLabs/sui#4760), so could we close this issue now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants