Skip to content

Commit 0026dda

Browse files
committed
fix issue #10222: mythcommflag segfaulting
The problem in issue #10222 is that it is adding the CODEC_FLAG2_FAST flag.  This causes unsafe functions to be used, causing a segfault. The proper way to fix this would probably be to figure out how to test for the "experimental speedups" flag, however I don't know the codebase well enough for this. I tested how this would affect the speed of mythcommflag on one of my recordings.  The results: Before removing flag: real 2m13.123s user 2m16.713s sys 0m3.502s After removing flag: real 2m13.021s user 2m15.446s sys 0m3.758s
1 parent c0bc928 commit 0026dda

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

mythtv/libs/libmythtv/avformatdecoder.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1380,8 +1380,6 @@ void AvFormatDecoder::InitVideoCodec(AVStream *stream, AVCodecContext *enc,
13801380
FlagIsSet(kDecodeFewBlocks) || FlagIsSet(kDecodeNoLoopFilter) ||
13811381
FlagIsSet(kDecodeNoDecode))
13821382
{
1383-
enc->flags2 |= CODEC_FLAG2_FAST;
1384-
13851383
if ((AV_CODEC_ID_MPEG2VIDEO == codec->id) ||
13861384
(AV_CODEC_ID_MPEG1VIDEO == codec->id))
13871385
{

0 commit comments

Comments
 (0)