Subtitles: Don't use a persistent DB setting to control forced subtit…

…les.

Instead, always allow forced subtitles when playback starts, and allow
the user to disable/enable forced subtitles during the current
playback.

mythtv/libs/libmythtv/mythplayer.cpp

@@ -244,7 +244,6 @@ MythPlayer::MythPlayer(PlayerFlags flags)
     endExitPrompt      = gCoreContext->GetNumSetting("EndOfRecordingExitPrompt");
     pip_default_loc    = (PIPLocation)gCoreContext->GetNumSetting("PIPLocation", kPIPTopLeft);
     tc_wrap[TC_AUDIO]  = gCoreContext->GetNumSetting("AudioSyncOffset", 0);
-    allowForcedSubtitles = gCoreContext->GetNumSetting("AllowForcedSubtitles", 1);
 
     // Get VBI page number
     QString mypage = gCoreContext->GetSetting("VBIpageNr", "888");
@@ -1578,11 +1577,6 @@ void MythPlayer::SetAllowForcedSubtitles(bool allow)
                       tr("Forced Subtitles On") :
                       tr("Forced Subtitles Off"),
                   kOSDTimeout_Med);
-    if (old != allowForcedSubtitles)
-    {
-        gCoreContext->SaveSetting("AllowForcedSubtitles",
-                                  allowForcedSubtitles);
-    }
 }
 
 void MythPlayer::DoDisableForcedSubtitles(void)