Skip to content

Commit

Permalink
Remove unused DBCleanup housekeeping job.
Browse files Browse the repository at this point in the history
The DBCleanup job was added 4 years ago in 9c0fa01 as a workaround
for an issue reported in #5482.  However, the job's last run time was
never updated, meaning the job only ever ran a single time on any MythTV
system since it was added.  This seems to indicate that running it as a
daily job is unnecessary.  Furthermore, DB connection handling has been
completely rewritten to use per-thread connection pools, and both MySQL
and Qt-MySQL have changed significantly in that time, so the old
workaround for an old MySQL issue is no longer required.  And
MDBManager::PurgeIdleConnections() is now used by MDBManager's
push/popConnection() functions and MPoolThread::run(), so the
originally-intended function of the patch (cleaning up idle connections
when no longer required) is now handled--more responsively--by the DB
connection pooling code, itself.
  • Loading branch information
sphery committed Jun 14, 2012
1 parent af3f939 commit 13f3b77
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions mythtv/programs/mythbackend/housekeeper.cpp
Expand Up @@ -331,11 +331,6 @@ void HouseKeeper::RunHouseKeeping(void)
updateLastrun(dbTag);
}

if (wantToRun("DBCleanup", 1, 0, 24))
{
gCoreContext->GetDBManager()->PurgeIdleConnections();
}

initialRun = false;

locker.relock();
Expand Down

0 comments on commit 13f3b77

Please sign in to comment.