Skip to content

Commit

Permalink
Check albumart_image is not NULL in MusicMetadata::getAlbumArtFile()
Browse files Browse the repository at this point in the history
Fixes Coverity ID 1023882 Dereference after null check.

This would appear to be false positive in that if res is not empty then
albumart_image cannot be NULL anyway.
  • Loading branch information
Paul Harrison committed May 27, 2013
1 parent 5de785c commit 1d788c1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mythtv/libs/libmythmetadata/musicmetadata.cpp
Expand Up @@ -966,7 +966,7 @@ QString MusicMetadata::getAlbumArtFile(void)
res = albumart_image->filename;

// check file exists
if (!res.isEmpty())
if (!res.isEmpty() && albumart_image)
{
int repo = ID_TO_REPO(m_id);
if (repo == RT_Radio)
Expand Down

0 comments on commit 1d788c1

Please sign in to comment.