Skip to content
Permalink
Browse files

Disable Picture-In-Picture and Picture-By-Picture

This was broken by recent threading changes. Unfortunately there is a
large chunk of code in the TV class that needs cleaning up before it can
be properly fixed, hence I'm disabling for the time being rather than
add workarounds.

I'll 'rebuild' PiP/PBP once the main playback thread issues have been
resolved.
  • Loading branch information
Mark Kendall
Mark Kendall committed Feb 9, 2011
1 parent 90b7223 commit 27e125fd73cc02634af4ff035a51a718454132eb
@@ -43,7 +43,7 @@ class VideoOutputD3D : public VideoOutput
MythPlayer *pipplayer,
PIPLocation loc);
void RemovePIP(MythPlayer *pipplayer);
bool IsPIPSupported(void) const { return true; }
bool IsPIPSupported(void) const { return false; /*true*/}
virtual MythPainter *GetOSDPainter(void) { return (MythPainter*)m_osd_painter; }

private:
@@ -46,7 +46,7 @@ class VideoOutputOpenGL : public VideoOutput
void MoveResizeWindow(QRect new_rect);

virtual void RemovePIP(MythPlayer *pipplayer);
virtual bool IsPIPSupported(void) const { return true; }
virtual bool IsPIPSupported(void) const { return false/*true*/; }
virtual bool hasFullScreenOSD(void) const { return true; }
virtual bool IsSyncLocked(void) const { return true; }
virtual bool ApproveDeintFilter(const QString& filtername) const;
@@ -55,7 +55,7 @@ class VideoOutputVDPAU : public VideoOutput
static MythCodecID GetBestSupportedCodec(uint width, uint height,
uint stream_type,
bool no_acceleration);
virtual bool IsPIPSupported(void) const { return true; }
virtual bool IsPIPSupported(void) const { return false;/*true; */}
virtual bool IsPBPSupported(void) const { return false; }
virtual bool NeedExtraAudioDecode(void) const
{ return codec_is_vdpau(video_codec_id); }
@@ -70,9 +70,9 @@ class VideoOutputXv : public VideoOutput
void InitPictureAttributes(void);

virtual bool IsPIPSupported(void) const
{ return XVideo == VideoOutputSubType(); }
{ return false; /*XVideo == VideoOutputSubType(); */}
virtual bool IsPBPSupported(void) const
{ return XVideo == VideoOutputSubType(); }
{ return false; /*return XVideo == VideoOutputSubType(); */}
virtual bool NeedExtraAudioDecode(void) const { return false; }

virtual QRect GetPIPRect(PIPLocation location,

0 comments on commit 27e125f

Please sign in to comment.
You can’t perform that action at this time.