Please sign in to comment.
libmythui: Fix a redraw bug in MythUIType
While evaluating the ATI Catalyst 'TearFree Desktop' option I noticed that sometimes a keypress was apparently being held up until the time on the main menu was updated. Initially I thought that this was a lirc or fglrx issue, but on investigation it turned out that MythMainWindow::animate was requesting updates for empty repaint regions. Delving further showed that MythUIType::Draw was resetting m_DirtyRegion to empty even if the clipRect was smaller, thus leaving unpainted regions. m_DirtyRegion may be extended by HandleMovementPulse, SetRedraw or SetChildNeedsRedraw etc AFTER GetDirtyArea is called. So when MythUIType::Draw is called, clipRect may not include the whole of m_DirtyRegion. This patch subtracts the Draw clipRect from m_DirtyRegion instead of simply emtying it. Fixes #10695 Signed-off-by: Lawrence Rust <firstname.lastname@example.org> Signed-off-by: Stuart Morgan <email@example.com>
- Loading branch information...