Coverity warning: if a cast failed, ConnectBackend() will be called w…

…ith a null. Likelihood of 0.1%, but there was once a compiler bug that did this for events.
MythTV · May 27, 2013 · 4265bb7 · 4265bb7
1 parent a142943
commit 4265bb7
Showing 1 changed file with 6 additions and 1 deletion.
diff --git a/mythtv/libs/libmyth/backendselect.cpp b/mythtv/libs/libmyth/backendselect.cpp
@@ -93,9 +93,14 @@ void BackendSelection::Accept(MythUIButtonListItem *item)
     DeviceLocation *dev = qVariantValue<DeviceLocation *>(item->GetData());
 
     if (!dev)
+    {
         Cancel();
+        LOG(VB_GENERAL, LOG_ERR,
+            "Could not get device details from UI element?");
+        return;
+    }
 
-    if (ConnectBackend(dev))  // this does a Release()
+    if (ConnectBackend(dev))
     {
         if (m_pConfig)
         {