Permalink
Browse files

mythtranscode: Avoid a floating point exception

Closes #10263

When mythtranscode is run with a non default profile it can
throw a flating point exception during initialisation:

Program terminated with signal 8, Arithmetic exception.

422	    if ((ydiff / display_video_rect.height()) < 0.05)
(gdb) bt
    new_display_visible_rect=..., new_aspectoverride=kAspect_Off, new_adjustfill=kAdjustFill_AutoDetect_DefaultHalf)
    at videooutwindow.cpp:484
    winh=0, codec_id=kCodec_MPEG2, embedid=0) at videooutbase.cpp:419
    winw=0, winh=0, codec_id=kCodec_MPEG2, embedid=0) at videoout_null.cpp:152
    framecontrol=false, jobID=-1, fifodir=..., fifo_info=false, deleteMap=...) at transcode.cpp:716

This is caused by display_video_rect.height() being 0.

Signed-off-by: Lawrence Rust <lvr@softsystem.co.uk>
Signed-off-by: Gavin Hurlbut <ghurlbut@mythtv.org>
  • Loading branch information...
Lawrence Rust authored and Beirdo committed Jan 15, 2012
1 parent a4d27a4 commit 50b459419b1c79f311c2b7f56ba0fd64f8562ec8
Showing with 3 additions and 0 deletions.
  1. +3 −0 mythtv/libs/libmythtv/videooutwindow.cpp
@@ -444,6 +444,9 @@ void VideoOutWindow::ApplySnapToVideoRect(void)
if (pip_state > kPIPOff)
return;
+ if (display_video_rect.height() == 0 || display_video_rect.width() == 0)
+ return;
+
float ydiff = abs(display_video_rect.height() - video_rect.height());
if ((ydiff / display_video_rect.height()) < 0.05)
{

0 comments on commit 50b4594

Please sign in to comment.