Skip to content

Commit

Permalink
VideoDialog: fix coverity ID 746884 Uninitialized pointer field
Browse files Browse the repository at this point in the history
In VideoDialog::VideoDialog(): Several pointer fields are not initialized in
the constructor.
  • Loading branch information
Paul Harrison committed Jun 12, 2013
1 parent 4802db2 commit 574973e
Showing 1 changed file with 25 additions and 14 deletions.
39 changes: 25 additions & 14 deletions mythtv/programs/mythfrontend/videodlg.cpp
Expand Up @@ -835,27 +835,38 @@ VideoDialog::VideoListDeathDelayPtr &VideoDialog::GetSavedVideoList()
}

VideoDialog::VideoDialog(MythScreenStack *lparent, QString lname,
VideoListPtr video_list, DialogType type, BrowseType browse) :
MythScreenType(lparent, lname), m_menuPopup(0), m_busyPopup(0),
m_videoButtonList(0), m_videoButtonTree(0), m_titleText(0),
m_novideoText(0), m_positionText(0), m_crumbText(0), m_coverImage(0),
m_screenshot(0), m_banner(0), m_fanart(0), m_trailerState(0),
m_parentalLevelState(0), m_watchedState(0), m_studioState(0)
VideoListPtr video_list, DialogType type, BrowseType browse)
: MythScreenType(lparent, lname),
m_menuPopup(NULL),
m_busyPopup(NULL),
m_popupStack(GetMythMainWindow()->GetStack("popup stack")),
m_mainStack(GetMythMainWindow()->GetMainStack()),
m_videoButtonList(NULL),
m_videoButtonTree(NULL),
m_titleText(NULL),
m_novideoText(NULL),
m_positionText(NULL),
m_crumbText(NULL),
m_coverImage(NULL),
m_screenshot(NULL),
m_banner(NULL),
m_fanart(NULL),
m_trailerState(NULL),
m_parentalLevelState(NULL),
m_videoLevelState(NULL),
m_userRatingState(NULL),
m_watchedState(NULL),
m_studioState(NULL),
m_metadataFactory(new MetadataFactory(this)),
m_d(new VideoDialogPrivate(video_list, type, browse))
{
m_metadataFactory = new MetadataFactory(this);

m_d = new VideoDialogPrivate(video_list, type, browse);

m_popupStack = GetMythMainWindow()->GetStack("popup stack");
m_mainStack = GetMythMainWindow()->GetMainStack();

m_d->m_videoList->setCurrentVideoFilter(VideoFilterSettings(true,
lname));

m_d->m_parentalLevel.SetLevel(ParentalLevel(gCoreContext->
GetNumSetting("VideoDefaultParentalLevel",
ParentalLevel::plLowest)));

StorageGroup::ClearGroupToUseCache();
}

Expand Down

0 comments on commit 574973e

Please sign in to comment.