Skip to content

Commit

Permalink
IPTVSignalMonitor: Fix Coverity ID 746869 & 746790
Browse files Browse the repository at this point in the history
m_streamHandlerStarted was never initialised in the ctor so the random value
was used later (looks like a genuine bug).

Comment out for now the dead code which will be used once danielk fixes the
TODO and initialises isLocked to the correct value :)
  • Loading branch information
Paul Harrison committed Jun 24, 2013
1 parent 2c9bc10 commit 5f23db5
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions mythtv/libs/libmythtv/recorders/iptvsignalmonitor.cpp
Expand Up @@ -26,6 +26,7 @@ IPTVSignalMonitor::IPTVSignalMonitor(int db_cardnum,
IPTVChannel *_channel,
uint64_t _flags) :
DTVSignalMonitor(db_cardnum, _channel, _flags),
m_streamHandlerStarted(false),
m_lock_timeout(1000 * 60 /* 1 minute */)
{
LOG(VB_CHANNEL, LOG_INFO, LOC + "ctor");
Expand All @@ -34,8 +35,8 @@ IPTVSignalMonitor::IPTVSignalMonitor(int db_cardnum,
bool isLocked = true;

QMutexLocker locker(&statusLock);
signalLock.SetValue((isLocked) ? 1 : 0);
signalStrength.SetValue((isLocked) ? 100 : 0);
signalLock.SetValue(1 /*(isLocked) ? 1 : 0*/);
signalStrength.SetValue(100 /*(isLocked) ? 100 : 0*/);
}

/** \fn IPTVSignalMonitor::~IPTVSignalMonitor()
Expand Down

0 comments on commit 5f23db5

Please sign in to comment.