Don't add an invalid (null) image to the image cache

MythTV · Aug 4, 2013 · 663cca3 · 663cca3
1 parent 53b0212
commit 663cca3
Showing 1 changed file with 10 additions and 10 deletions.
diff --git a/mythtv/libs/libmythui/mythuiimage.cpp b/mythtv/libs/libmythui/mythuiimage.cpp
@@ -289,6 +289,16 @@ class ImageLoader
             }
         }
 
+        if (image && image->isNull())
+        {
+            LOG(VB_GUI | VB_FILE, LOG_INFO,
+                QString("ImageLoader::LoadImage(%1) Image is NULL")
+                                                    .arg(filename));
+
+            image->DecrRef();
+            image = NULL;
+        }
+
         if (image && !bFoundInCache)
         {
             if (bForceResize)
@@ -328,16 +338,6 @@ class ImageLoader
                 GetMythUI()->CacheImage(cacheKey, image);
         }
 
-        if (image && image->isNull())
-        {
-            LOG(VB_GUI | VB_FILE, LOG_INFO,
-                QString("ImageLoader::LoadImage(%1) Image is NULL")
-                                                    .arg(filename));
-
-            image->DecrRef();
-            image = NULL;
-        }
-
         if (image)
             image->SetChanged();