Skip to content

Commit

Permalink
Fix memory leak in AudioOutputPulseAudio(). The code in question seem…
Browse files Browse the repository at this point in the history
…s to serve no purpose but on the offchance that I'm wrong I've kept in place and just ensured that we cleanup after it.
  • Loading branch information
stuartm committed May 19, 2012
1 parent 99ebebd commit 6655d24
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion mythtv/libs/libmyth/audio/audiooutputpulse.cpp
Expand Up @@ -34,7 +34,11 @@ AudioOutputPulseAudio::AudioOutputPulseAudio(const AudioSettings &settings) :
for (unsigned int i = 0; i < PA_CHANNELS_MAX; ++i)
volume_control.values[i] = PA_VOLUME_MUTED;

ChooseHost();
// FIXME What's this all about? It's a const method, it doesn't modify the
// state and we ignore the result
char *pulse_host = ChooseHost();
delete[] pulse_host;
//

InitSettings(settings);
if (settings.init)
Expand Down

0 comments on commit 6655d24

Please sign in to comment.