Silence coverity warning about possible null pointer dereference (fal…

…se positive). Coverity 746813
MythTV · Jun 3, 2013 · 7a5961f · 7a5961f
1 parent a7c0e41
commit 7a5961f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/mythtv/libs/libmythui/xmlparsebase.cpp b/mythtv/libs/libmythui/xmlparsebase.cpp
@@ -517,7 +517,7 @@ MythUIType *XMLParseBase::ParseUIType(
         return NULL;
     }
 
-    if (olduitype)
+    if (olduitype && parent)
     {
         if (typeid(*olduitype) != typeid(*uitype))
         {
@@ -540,7 +540,8 @@ MythUIType *XMLParseBase::ParseUIType(
             VERBOSE_XML(VB_GENERAL, LOG_ERR, filename, element,
                       QString("Type of new widget '%1' doesn't match old '%2'")
                         .arg(name).arg(inherits));
-            parent->DeleteChild(uitype);
+            if (parent)
+                parent->DeleteChild(uitype);
             return NULL;
         }
         else