Fix coverity report

Big parameter passed by value: Passing parameter settings of type AudioOutputSettings (size 624 bytes) by value. Use reference instead. Coverity-Id: 700625
MythTV · Jun 21, 2013 · 8c31549 · 8c31549
1 parent 473130b
commit 8c31549
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 6 deletions.
diff --git a/mythtv/programs/mythfrontend/audiogeneralsettings.cpp b/mythtv/programs/mythfrontend/audiogeneralsettings.cpp
@@ -555,7 +555,7 @@ void AudioConfigSettings::StartAudioTest()
 AudioTestThread::AudioTestThread(QObject *parent,
                                  QString main, QString passthrough,
                                  int channels,
-                                 AudioOutputSettings settings,
+                                 AudioOutputSettings &settings,
                                  bool hd) :
     MThread("AudioTest"),
     m_parent(parent), m_channels(channels), m_device(main),
@@ -721,7 +721,7 @@ void AudioTestThread::run()
 }
 
 AudioTest::AudioTest(QString main, QString passthrough,
-                     int channels, AudioOutputSettings settings) 
+                     int channels, AudioOutputSettings &settings)
     : VerticalConfigurationGroup(false, true, false, false),
       m_frontleft(NULL), m_frontright(NULL), m_center(NULL),
       m_surroundleft(NULL), m_surroundright(NULL),
@@ -969,7 +969,7 @@ bool AudioTest::event(QEvent *event)
 
 
 AudioTestGroup::AudioTestGroup(QString main, QString passthrough,
-                               int channels, AudioOutputSettings settings)
+                               int channels, AudioOutputSettings &settings)
 {
     addChild(new AudioTest(main, passthrough, channels, settings));
 }

diff --git a/mythtv/programs/mythfrontend/audiogeneralsettings.h b/mythtv/programs/mythfrontend/audiogeneralsettings.h
@@ -129,7 +129,7 @@ class AudioTestGroup : public ConfigurationWizard
 {
   public:
     AudioTestGroup(QString main, QString passthrough,
-                   int channels, AudioOutputSettings settings);
+                   int channels, AudioOutputSettings &settings);
 };
 
 class ChannelChangedEvent : public QEvent
@@ -150,7 +150,7 @@ class AudioTestThread : public MThread
   public:
 
     AudioTestThread(QObject *parent, QString main, QString passthrough,
-                    int channels, AudioOutputSettings settings, bool hd);
+                    int channels, AudioOutputSettings &settings, bool hd);
     ~AudioTestThread();
 
     void cancel();
@@ -178,7 +178,7 @@ class AudioTest : public VerticalConfigurationGroup
     Q_OBJECT
   public:
     AudioTest(QString main, QString passthrough,
-              int channels, AudioOutputSettings settings);
+              int channels, AudioOutputSettings &settings);
     ~AudioTest();
     bool event(QEvent *event);