Avoid unnecessary QString copy. (cppcheck)

MythTV · Oct 3, 2012 · 8c8b75e · 8c8b75e
1 parent 19241fe
commit 8c8b75e
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 6 deletions.
diff --git a/mythtv/libs/libmythbase/mythsystem.h b/mythtv/libs/libmythbase/mythsystem.h
@@ -154,7 +154,7 @@ class MBASE_PUBLIC MythSystemPrivate : public QObject, public ReferenceCounter
         virtual void Signal(int sig) = 0;
         virtual void JumpAbort(void) = 0;
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args) = 0;
 
     protected:

diff --git a/mythtv/libs/libmythbase/system-unix.cpp b/mythtv/libs/libmythbase/system-unix.cpp
@@ -590,7 +590,7 @@ MythSystemUnix::~MythSystemUnix(void)
 {
 }
 
-bool MythSystemUnix::ParseShell(const QString cmd, QString &abscmd,
+bool MythSystemUnix::ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args)
 {
     QList<QChar> whitespace; whitespace << ' ' << '\t' << '\n' << '\r';

diff --git a/mythtv/libs/libmythbase/system-unix.h b/mythtv/libs/libmythbase/system-unix.h
@@ -91,7 +91,7 @@ class MBASE_PUBLIC MythSystemUnix : public MythSystemPrivate
         virtual void Signal(int sig);
         virtual void JumpAbort(void);
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args);
 
         friend class MythSystemManager;

diff --git a/mythtv/libs/libmythbase/system-windows.cpp b/mythtv/libs/libmythbase/system-windows.cpp
@@ -545,8 +545,7 @@ MythSystemWindows::~MythSystemWindows(void)
 {
 }
 
-bool MythSystemWindows::ParseShell(const QString cmd, QString &abscmd,
-                                   QStringList &args)
+bool MythSystemWindows::ParseShell(const QString&, QString &, QStringList&)
 {
     return false;
 }

diff --git a/mythtv/libs/libmythbase/system-windows.h b/mythtv/libs/libmythbase/system-windows.h
@@ -90,7 +90,7 @@ class MBASE_PUBLIC MythSystemWindows : public MythSystemPrivate
         virtual void Signal(int sig);
         virtual void JumpAbort(void);
 
-        virtual bool ParseShell(const QString cmd, QString &abscmd,
+        virtual bool ParseShell(const QString &cmd, QString &abscmd,
                                 QStringList &args);
 
         friend class MythSystemManager;