Skip to content

Commit

Permalink
Remove the 1088->1080 translation in the preview generator.
Browse files Browse the repository at this point in the history
Instead, compute the dimensions from the player's display dimension.
  • Loading branch information
stichnot committed Mar 6, 2013
1 parent 20c28b9 commit 9f9e720
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 12 deletions.
4 changes: 2 additions & 2 deletions mythtv/libs/libmythtv/mythplayer.cpp
Expand Up @@ -4344,8 +4344,8 @@ char *MythPlayer::GetScreenGrabAtFrame(uint64_t frameNum, bool absolute,
&retbuf, PIX_FMT_RGB32, &orig, PIX_FMT_YUV420P,
video_dim.width(), video_dim.height());

vw = video_dim.width();
vh = video_dim.height();
vw = video_disp_dim.width();
vh = video_disp_dim.height();
ar = frame->aspect;

DiscardVideoFrame(frame);
Expand Down
10 changes: 0 additions & 10 deletions mythtv/libs/libmythtv/previewgenerator.cpp
Expand Up @@ -548,16 +548,6 @@ bool PreviewGenerator::SavePreview(QString filename,
if (!data || !width || !height)
return false;

if( height == 1088 )
{
// Remove the extra 8 pixels at the bottom of 1080i recordings that
// decode to 1088 rows as these are bogus pixels and make the previews
// look a bit wrong. The worst offender seems to be H.264 captures
// from HDPVR. Apparently, BBC HD also may exhibit the same behavior
// in the UK, although with a different width.
height = 1080;
}

const QImage img((unsigned char*) data,
width, height, QImage::Format_RGB32);

Expand Down

0 comments on commit 9f9e720

Please sign in to comment.