Skip to content

Commit

Permalink
Use RemoteFile::isOpen() instead of Open() to check for success.
Browse files Browse the repository at this point in the history
Calling Open() was unnecessarily creating extra socket connections to
the backend, and the original socket connections from calling Open()
in the constructor were leaking and accumulating in both the frontend
and backend (refs #11341).  Refs #11618
  • Loading branch information
stichnot committed Jun 24, 2013
1 parent 24c86d3 commit ba75244
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion mythtv/libs/libmythtv/textsubtitleparser.cpp
Expand Up @@ -147,7 +147,7 @@ bool TextSubtitleParser::LoadSubtitles(const QString &fileName,

LOG(VB_VBI, LOG_INFO,
QString("Preparing to load subtitle file (%1)").arg(fileName));
if (!rfile.Open())
if (!rfile.isOpen())
{
LOG(VB_VBI, LOG_INFO,
QString("Failed to load subtitle file (%1)").arg(fileName));
Expand Down

0 comments on commit ba75244

Please sign in to comment.