Fix memory leak in MetaIOTagLib::getTrackLength(const QString &filename)

MythTV · May 24, 2012 · e8aef6a · e8aef6a
1 parent 7d4b285
commit e8aef6a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/mythplugins/mythmusic/mythmusic/metaioid3.cpp b/mythplugins/mythmusic/mythmusic/metaioid3.cpp
@@ -201,7 +201,7 @@ bool MetaIOID3::write(const Metadata* mdata)
         {
             tpe4frame = new TextIdentificationFrame(TagLib::ByteVector("TPE4"),
                                                     TagLib::String::UTF8);
-                                                    tag->addFrame(tpe4frame);
+            tag->addFrame(tpe4frame);
         }
         tpe4frame->setText(QStringToTString(mdata->CompilationArtist()));
 
@@ -215,7 +215,7 @@ bool MetaIOID3::write(const Metadata* mdata)
         {
             tpe2frame = new TextIdentificationFrame(TagLib::ByteVector("TPE2"),
                                                     TagLib::String::UTF8);
-                                                    tag->addFrame(tpe2frame);
+            tag->addFrame(tpe2frame);
         }
         tpe2frame->setText(QStringToTString(mdata->CompilationArtist()));
     }

diff --git a/mythplugins/mythmusic/mythmusic/metaiotaglib.cpp b/mythplugins/mythmusic/mythmusic/metaiotaglib.cpp
@@ -122,6 +122,8 @@ int MetaIOTagLib::getTrackLength(const QString &filename)
         LOG(VB_GENERAL, LOG_ERR,
             QString("MetaIOTagLib: Failed to read length "
                     "from '%1'. It may be corrupt.").arg(filename));
+
+    delete file;
 
     return milliseconds;
 }