Change SignalMonitor shutdown so it works for IPTVSignalMonitor

The problem was mainly that the MThread::exit(0); wasn't being called when shutdown from the SignalMonitor dtor because it was calling it's version of SetRunningDesired() not the IPTVSignalMonitor version. But there also seems to be a problem wherein the MThread::exit(0); doesn't register with the QThread, so we now call it every 100 ms until it takes.
MythTV · Mar 9, 2012 · ed6ebe1 · ed6ebe1
1 parent f3e37ed
commit ed6ebe1
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 19 deletions.
diff --git a/mythtv/libs/libmythtv/iptvstreamhandler.cpp b/mythtv/libs/libmythtv/iptvstreamhandler.cpp
@@ -113,13 +113,6 @@ IPTVStreamHandler::IPTVStreamHandler(const IPTVTuningData &tuning) :
     m_use_rtp_streaming = m_tuning.GetDataURL().scheme().toUpper() == "RTP";
 }
 
-void IPTVStreamHandler::SetRunningDesired(bool desired)
-{
-    StreamHandler::SetRunningDesired(desired);
-    if (!desired)
-        exit(0);
-}
-
 void IPTVStreamHandler::run(void)
 {
     RunProlog();

diff --git a/mythtv/libs/libmythtv/iptvstreamhandler.h b/mythtv/libs/libmythtv/iptvstreamhandler.h
@@ -88,8 +88,6 @@ class IPTVStreamHandler : public StreamHandler
 
     virtual void run(void); // MThread
 
-    virtual void SetRunningDesired(bool desired); // StreamHandler
-
   private:
     IPTVTuningData m_tuning;
     QUdpSocket *m_sockets[IPTV_SOCKET_COUNT];

diff --git a/mythtv/libs/libmythtv/streamhandler.cpp b/mythtv/libs/libmythtv/streamhandler.cpp
@@ -175,17 +175,11 @@ void StreamHandler::Stop(void)
 {
     QMutexLocker locker(&_start_stop_lock);
 
-    do
+    while (_running)
     {
         SetRunningDesired(false);
-        while (!_running_desired && _running)
-            _running_state_changed.wait(&_start_stop_lock, 100);
-        if (_running_desired)
-        {
-            LOG(VB_GENERAL, LOG_WARNING, LOC +
-                "Programmer Error: Start called before Stop finished");
-        }
-    } while (_running_desired);
+        _running_state_changed.wait(&_start_stop_lock, 100);
+    }
 
     wait();
 }
@@ -207,6 +201,13 @@ void StreamHandler::SetRunning(bool is_running,
     _running_state_changed.wakeAll();
 }
 
+void StreamHandler::SetRunningDesired(bool desired)
+{
+    _running_desired = desired;
+    if (!desired)
+        MThread::exit(0);
+}
+
 bool StreamHandler::AddPIDFilter(PIDInfo *info)
 {
 #ifdef DEBUG_PID_FILTERS

diff --git a/mythtv/libs/libmythtv/streamhandler.h b/mythtv/libs/libmythtv/streamhandler.h
@@ -94,7 +94,7 @@ class StreamHandler : protected MThread, public DeviceReaderCB
     /// At minimum this sets _running_desired, this may also send
     /// signals to anything that might be blocking the run() loop.
     /// \note: The _start_stop_lock must be held when this is called.
-    virtual void SetRunningDesired(bool desired) { _running_desired = desired; }
+    void SetRunningDesired(bool desired);
 
   protected:
     QString           _device;