Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subclasses created by ShipDetailsScraper that were not originally found by ClassScraper are not assigned to any parent class #31

Open
Myuuiii opened this issue Dec 18, 2022 · 1 comment
Labels
bug Something isn't working PROJECT: API Related to the API

Comments

@Myuuiii
Copy link
Owner

Myuuiii commented Dec 18, 2022

Example for the Narwhal subclass. It should be a member of the Destroyer class yet it is not, the Narwhal subclass was added by the ShipDetailsScraper.

@Myuuiii Myuuiii added bug Something isn't working PROJECT: API Related to the API labels Dec 18, 2022
@Myuuiii
Copy link
Owner Author

Myuuiii commented Dec 18, 2022

Note that this can lead to update problems with the current configuration, if the user wants to update Nautilus in the database they will not be able to pass the PUT request validation as the API does not see Narwhal as a subclass of Destroyer class. A temporary fix can be put in place by checking if the given subclass is part of the given class, or if the subclass is not bound to any parent class

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working PROJECT: API Related to the API
Projects
Status: 📋 Backlog
Development

No branches or pull requests

1 participant