Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in v2.3-RC2 #420

Closed
1 of 3 tasks
testower opened this issue Mar 25, 2022 · 2 comments
Closed
1 of 3 tasks

Breaking change in v2.3-RC2 #420

testower opened this issue Mar 25, 2022 · 2 comments

Comments

@testower
Copy link
Contributor

testower commented Mar 25, 2022

As raised in slack earlier in the week.

What is the issue and why is it an issue?

I noticed there is a breaking change in v2.3-RC2, in vehicle_types.json, name in the conditional requirement of the new field "default_pricing_plan_id":

“REQUIRED if both system_pricing_plans.json and vehicle_types.json are defined.”

We are unable to complete implementation of this release candidate until this is solved.

Please describe some potential solutions you have considered (even if they aren’t related to GBFS).

The field should be made optional, and a conditional requirement can be added in v3.

Is your potential solution a breaking change?

  • Yes
  • No
  • Unsure
@mplsmitch
Copy link
Contributor

Thanks for Flagging this @testower - I'm updating the release candidate, should be completed sometime on Monday 3/28. I'll update this issue when the corrected release candidate is ready.

@mplsmitch
Copy link
Contributor

This change has been incorporated into v2.3-RC2 along with other minor corrections

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants