Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Phone Number to Field Types #351

Merged
merged 4 commits into from Jan 12, 2022
Merged

Add Phone Number to Field Types #351

merged 4 commits into from Jan 12, 2022

Conversation

josee-sabourin
Copy link
Contributor

What problem does your proposal solve? Please begin with the relevant issue number. If there is no existing issue, please also describe alternative solutions you have considered.

Phone number is not a defined Field Type however appears as a field type in system_information.json.

What is the proposal?

Add Phone Number as a defined Field Type using E.164 specification (Wikipedia here). Specifying no spaces, hyphens, or parentheses in the phone numbers.

Is this a breaking change?

  • Yes
  • No
  • Unsure

Which files are affected by this change?

  • system_information.json

josee-sabourin added 2 commits August 17, 2021 12:03
Add phone number to Field Types
23095b6 
Add phone number to field types
Update phone_number field in system_information.json
Update example
Update gbfs.md
ca965a9
@josee-sabourin josee-sabourin added proposal:breaking v3.0-RC Candidate change for GBFS 3.0 (Major release) labels Aug 17, 2021
@josee-sabourin
Expand phone_number field definition
f41dfb6 
Add link to E.164 documentation to phone_number field in system_information.json
@fchabouis fchabouis mentioned this pull request Aug 26, 2021
Merged
3 tasks
@mplsmitch
Copy link
Contributor

I hereby call a vote on this proposal. Voting will be open for 10 full calendar days until 11:59PM UTC on December 9, 2021.

Please vote for or against the proposal, and include the organization for which you are voting in your comment.

Please note if you can commit to implementing the proposal.

@kanagy
Copy link

kanagy commented Nov 29, 2021

+1 from Google Maps, but no plan for surfacing phone numbers yet.

@richtaylor-ito
Copy link
Contributor

+1 from Ito World.

@cmonagle
Copy link
Contributor

+1 from Transit

@testower
Copy link
Contributor

testower commented Dec 6, 2021

Entur supports this proposal

@nbdh
Copy link
Contributor

nbdh commented Dec 6, 2021

+1 from nextbike

@heidiguenin
Copy link
Contributor

Voting on this PR closes in 2 calendar days. Please vote for or against the proposal, and include the organization for which you are voting in your comment. Please note if you can commit to implementing the proposal.

@ncancelliere
Copy link

+1 from Spin.

@veddan
Copy link

veddan commented Dec 9, 2021

+1 from Move About

@heidiguenin
Copy link
Contributor

This vote has now closed, and it passes!

Votes in favor:
Google Maps (consumer)
Ito World (producer)
Transit (consumer)
Entur (consumer)
nextbike (producer)
Spin (producer)
Move About (producer)


There were no votes against.
Thank you to everyone who took the time to review and to vote on this!

We will tag and merge this into v3.0-RC2 in the coming weeks.

@mplsmitch mplsmitch merged commit 071fe68 into master Jan 12, 2022
@josee-sabourin josee-sabourin deleted the phone-number branch March 13, 2023 14:28
@isabelle-dr isabelle-dr mentioned this pull request Mar 16, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
v3.0-RC Candidate change for GBFS 3.0 (Major release) Vote Passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@josee-sabourin @mplsmitch @kanagy @richtaylor-ito @cmonagle @testower @nbdh @heidiguenin @ncancelliere @veddan