Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuARC does not pull in current master branch from pyQuARC repo #273

Closed
jenny-m-wood opened this issue Jan 24, 2024 · 5 comments
Closed

QuARC does not pull in current master branch from pyQuARC repo #273

jenny-m-wood opened this issue Jan 24, 2024 · 5 comments
Assignees

Comments

@jenny-m-wood
Copy link
Collaborator

Describe the bug
QuARC does not pull in the current master branch of the pyQuARC repo. It is pulling in an outdated version, so the recommendations do not align.

To Reproduce
Steps to reproduce the behavior:

  1. Go to QuARC and test using C1577484501-LARC_ASDC (umm-c)
  2. Run pyQuARC master branch on the record above
  3. See the discrepancies between the recommendations that pyQuARC's master branch provides and QuARC provides

Expected behavior
Expect the output from pyQuARC's master branch and output from QuARC to be identical.

Additional context
When briefly investigated, it seemed like it may be an issue with the Lambda function. An issue in QuARC was created for this in 2023 and may still exist.

@jenny-m-wood
Copy link
Collaborator Author

@xhagrg @slesaad ESDIS is promoting the use of QuARC for new missions such as PACE and NISAR, so please prioritize this ticket during pyQuARC development. Thanks!

@rajeshpandey2053 rajeshpandey2053 self-assigned this Mar 28, 2024
@jenny-m-wood
Copy link
Collaborator Author

Alternative example record: C2068391958-LARC_ASDC (format: umm-c)

@jenny-m-wood
Copy link
Collaborator Author

I compared pyQuARC output and QuARC output, and it looks much better! Thank you so much for making those updates @rajeshpandey2053

I did notice that the URL recommendations from pyQuARC were missing from QuARC. When testing on C2103888967-LARC (dif10), this recommendation was provided by pyQuARC:
Screenshot 2024-04-03 at 11 43 52 AM

QuARC however did not provide that recommendation, and this error message was shown:
Screenshot 2024-04-03 at 11 44 45 AM

I noticed something similar when testing with G1001367981-LARC (echo-g). Any thoughts on why this may be happening or the next steps for resolving?

@slesaad
Copy link
Member

slesaad commented Apr 3, 2024

@jenny-m-wood @rajeshpandey2053 is working on identifying what's causing it and then fixing it

@rajeshpandey2053
Copy link
Contributor

rajeshpandey2053 commented Apr 4, 2024

Issue

We are running pyQuARC in AWS Lambda functions to build the QuARC API. Lambda only supports a read-only file system. If someone attempts to write something to the Lambda, it throws an error. In our case, pyQuARC uses the urlextract package, which attempts to save some files in local storage for caching purposes, resulting in the error.
Initialize function for URLExtract class. Tries to get cached TLDs, if cached file does not exist it will try to download new list from IANA and save it to cache file.

Solution

We need to find an alternative solution to the urlextract package that does not rely on writing to the file system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants