Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E&A] Preselection of presets and hand-drawn polygons across page reloads #950

Open
dzole0311 opened this issue May 10, 2024 · 1 comment
Labels
P3 Place in the backlog so we don't lose track

Comments

@dzole0311
Copy link
Contributor

dzole0311 commented May 10, 2024

  1. When a preset is selected and the page is reloaded, the preset option is not shown as selected. We should probably keep this selection as a url parameter ("preset=Alaska") and then load it in the PresetSelector, so that the user knows which state was selected.
  2. Additionally, we should highlight the selected hand-drawn geometries on the map across page reloads. If I draw 3 polygons, select 2 of them and reload the page, they are not again selected due to diverging states between MapboxDraw and our React atoms. We already keep the state of the selected aois in the url, so we should switch those to "simple_select" mode so that they can be automatically highlighted
  3. It might be a good idea to differentiate the colors of the geometries based on if they are "static" (presets, file uploads) or hand-drawn (@faustoperez any thoughts?)
@faustoperez
Copy link

It might be a good idea to differentiate the colors of the geometries based on if they are "static" (presets, file uploads) or hand-drawn (@faustoperez any thoughts?)

To simplify the work I suggest (for now) that they be differentiated by the presence of the edit handles, but use the same "this is a shape" stroke and fill color 👍

@aboydnw aboydnw removed the bug label Jun 11, 2024
@aboydnw aboydnw added P3 Place in the backlog so we don't lose track and removed enhancement New feature or request labels Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P3 Place in the backlog so we don't lose track
Projects
None yet
Development

No branches or pull requests

3 participants