Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When installing the pds-doi-service from scratch I had an error with Flask version compatibility #199

Closed
tloubrieu-jpl opened this issue May 18, 2021 · 4 comments
Assignees
Labels
bug Something isn't working s.high

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

When running

pip install -r requirements.txt

on a new virtual environment there is an error with the Falsk version compatibility

📜 To Reproduce

Steps to reproduce the behavior:

  1. git clone ....
  2. python -m venv venv
  3. pip install -r requirements.txt

🕵️ Expected behavior

The pip install command should run without errors.

I think that works if I add an explicit version reference for Flask in the requirements.txt:

Flask==1.1.2

📚 Version of Software Used

Latest dev version on master

🩺 Test Data / Additional context

🏞Screenshots

🖥 System Info

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

** 🦄 Applicable requirements**

@tloubrieu-jpl
Copy link
Member Author

This error is impacting I&T (blocking it).

@jordanpadams jordanpadams removed their assignment May 27, 2021
@jordanpadams
Copy link
Member

@tloubrieu-jpl do we also to merge the doc changes from Eddie for Gary to test as part of this?

@tloubrieu-jpl
Copy link
Member Author

@jordanpadams yes good idea. Although the document changes are not as critical for Gary just today.

@jordanpadams jordanpadams changed the title When installing the ds-doi-service from scratch I had an error with Flask version compatibility When installing the pds-doi-service from scratch I had an error with Flask version compatibility May 27, 2021
@tloubrieu-jpl
Copy link
Member Author

The new dependency has been added on master branch with commit c70e01b#diff-4d7c51b1efe9043e44439a949dfd92e5827321b34082903477fd04876edb7552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working s.high
Projects
None yet
Development

No branches or pull requests

2 participants