Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

hits appears to be showing the current page count, not the overall number of its #199

Closed
Tracked by #30
jordanpadams opened this issue Jun 29, 2022 · 8 comments
Closed
Tracked by #30
Assignees
Labels
B13.0 B13.1 bug Something isn't working s.medium

Comments

@jordanpadams
Copy link
Member

jordanpadams commented Jun 29, 2022

馃悰 Describe the bug

Hits is returning 10000 when there are more than 10000 records in the Registry. Per https://opensearch.org/docs/latest/opensearch/ux/#paginate-results, it looks like we are grabbing this number from the size field returned from OpenSearch, vs. the _count.

馃摐 To Reproduce

Steps to reproduce the behavior:

  1. Go to https://pds.nasa.gov/api/search/1.0/products
  2. See:
{
  "summary" : {
    "q" : "",
    "hits" : 10000, <<<<<< not correct
    "took" : 846,
    "start" : 0,
    "limit" : 100,
    "sort" : [ ],
@tloubrieu-jpl
Copy link
Member

It used to work

@al-niessner
Copy link
Contributor

That is the window limitation. It is fixed with NASA-PDS/registry-mgr#53

@gxtchen
Copy link

gxtchen commented Jan 17, 2023

How is this fixed? It always returns 10000. I also followed the links in NASA-PDS/registry-mgr#53
The hits are also 10000.

@al-niessner
Copy link
Contributor

@gxtchen @jordanpadams @jimmie @tloubrieu-jpl

The 10000 makes me think you are on a node that is running with the opensearch default configuration which limits the total number of hits it can find to 10000 -- not exactly true but piratically true. Changing the opensearch configuration will fix it but if the configuration has already changed then this is a new item.

@jordanpadams
Copy link
Member Author

@gxtchen where are you seeing this issue? in operations?

@jordanpadams
Copy link
Member Author

@alexdunnjpl are we still seeing this in ops?

@alexdunnjpl
Copy link

@jordanpadams this might not be answering your question, but this is not an issue given

  • latest main state of registry-api
  • production pds registry OpenSearch

Outside of that configuration, it'd need to be tested.

@jordanpadams
Copy link
Member Author

@alexdunnjpl 馃憤 sounds like this is a local testing issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.0 B13.1 bug Something isn't working s.medium
Projects
None yet
Development

No branches or pull requests

5 participants